Skip to content

Conversation

daviian
Copy link
Member

@daviian daviian commented May 10, 2018

Targets #3730

PR reduces overall z-index of floating labels. However respects corner cases when used in dropdowns.

@codecov-io
Copy link

codecov-io commented May 10, 2018

Codecov Report

Merging #3939 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3939   +/-   ##
=======================================
  Coverage   20.27%   20.27%           
=======================================
  Files         146      146           
  Lines       29316    29316           
=======================================
  Hits         5945     5945           
  Misses      22470    22470           
  Partials      901      901

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 253a2d6...ba66bea. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 10, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 10, 2018
@lunny lunny added this to the 1.5.0 milestone May 10, 2018
@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels May 10, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2018
@lafriks lafriks mentioned this pull request May 10, 2018
7 tasks
@appleboy appleboy merged commit 91b3615 into go-gitea:master May 11, 2018
@appleboy
Copy link
Member

@daviian Plase send PR to v1.4 release branch.

@daviian daviian deleted the fix-badge-overlap branch May 11, 2018 09:53
daviian added a commit to daviian/gitea that referenced this pull request May 11, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants